Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove RELAY_NATIVE_SWAPS feature #4304

Merged
merged 2 commits into from
Oct 10, 2024
Merged

fix: remove RELAY_NATIVE_SWAPS feature #4304

merged 2 commits into from
Oct 10, 2024

Conversation

iamacook
Copy link
Member

@iamacook iamacook commented Oct 2, 2024

What it solves

Removes RELAY_NATIVE_SWAPS feature.

How this PR fixes it

As relaying will be "normalised", there is no longer use for this feature. As such, it removes the feature flag and associated implementation.

How to test it

Observe no swap-specific relaying on Arbitrum, rather "normal" relaying.

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

@iamacook iamacook self-assigned this Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Copy link

github-actions bot commented Oct 2, 2024

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 961.09 KB (-12 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/new-safe/advanced-create 35.08 KB (🟢 -47 B) 996.17 KB
/new-safe/create 34.35 KB (🟢 -47 B) 995.44 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

github-actions bot commented Oct 2, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.09% 12000/15366
🔴 Branches
58.14% (-0.03% 🔻)
3080/5298
🟡 Functions 65.09% 1889/2902
🟡 Lines 79.63% 10831/13601

Test suite run success

1482 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from 25cdc41

@iamacook iamacook marked this pull request as ready for review October 8, 2024 10:05
@iamacook iamacook merged commit 01cffdb into dev Oct 10, 2024
15 checks passed
@iamacook iamacook deleted the remove-swaps-relaying branch October 10, 2024 08:55
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants